Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(unity): Remove databricks_cli and cleanup #8249

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from treff7es June 15, 2023 23:18
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 15, 2023
@@ -348,8 +348,8 @@ def _create_query(info: QueryInfo) -> Query:
query_id=info.query_id,
query_text=info.query_text,
statement_type=info.statement_type,
start_time=datetime.utcfromtimestamp(info.query_start_time_ms / 1000),
end_time=datetime.utcfromtimestamp(info.query_end_time_ms / 1000),
start_time=datetime.fromtimestamp(info.query_start_time_ms / 1000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the timezone as well?

@anshbansal anshbansal merged commit 5843667 into datahub-project:master Jun 23, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants