Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/okta): Set default of okta_profile_to_username_attr to email #8263

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix(ingest/okta): Set default of okta_profile_to_username_attr to email #8263

merged 2 commits into from
Jun 21, 2023

Conversation

asikowitz
Copy link
Collaborator

Don't really know this connector but seems like this is what was requested

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 20, 2023
@anshbansal
Copy link
Collaborator

As this is a breaking change please add a note in Updating DataHub doc please. Other than that this looks good.

anshbansal
anshbansal approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Wait for CI to be green before doing merge

@anshbansal anshbansal merged commit 02bc71d into datahub-project:master Jun 21, 2023
45 checks passed
@anshbansal anshbansal mentioned this pull request Jun 21, 2023
Merged
5 tasks
@asikowitz asikowitz deleted the update-okta-config-default branch June 21, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@treff7es treff7es Awaiting requested review from treff7es

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asikowitz @anshbansal