Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add docs on update description via graphQL #8289

Merged
merged 5 commits into from
Jul 17, 2023
Merged

fix: add docs on update description via graphQL #8289

merged 5 commits into from
Jul 17, 2023

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Jun 23, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

resolves DR-457

@yoonhyejin yoonhyejin requested a review from hsheth2 June 23, 2023 05:19
@github-actions github-actions bot added the docs Issues and Improvements to docs label Jun 23, 2023
hsheth2
hsheth2 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

I didn't actually test the queries myself but assuming they're correct

docs/api/tutorials/descriptions.md Outdated Show resolved Hide resolved
docs/api/tutorials/descriptions.md Show resolved Hide resolved
@anshbansal anshbansal merged commit 9949f2c into master Jul 17, 2023
1 of 2 checks passed
@anshbansal anshbansal deleted the docs/updateDescription branch July 17, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoonhyejin @hsheth2 @anshbansal @acryl-hyejin