Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(embed): set embed url to false for tableau config #8308

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(embed): set embed url to false for tableau config #8308

merged 2 commits into from
Jun 27, 2023

Conversation

gabe-lyons
Copy link
Contributor

In #8307 I hide the embed previews for Tableau in the UI. For those who won't update their UI, lets not continue creating bad embed tabs.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 26, 2023
@asikowitz
Copy link
Collaborator

Looks like you have to update a golden or two

@gabe-lyons gabe-lyons merged commit d075bb4 into datahub-project:master Jun 27, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabe-lyons @asikowitz