Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/looker): Fix typo on ViewField creation for measures #8318

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(ingest/looker): Fix typo on ViewField creation for measures #8318

merged 1 commit into from
Jun 28, 2023

Conversation

asikowitz
Copy link
Collaborator

Getting errors here, just looks like a typo to me

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jun 27, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Jun 27, 2023

@Mohd-gslab - do you know why this wasn't caught by our testing?

@anshbansal anshbansal merged commit 1f0723f into datahub-project:master Jun 28, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@siddiquebagwan-gslab siddiquebagwan-gslab Awaiting requested review from siddiquebagwan-gslab

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asikowitz @hsheth2 @anshbansal