Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(async): submit additional default aspects only when not in async mode #8320

Merged
merged 2 commits into from
Jun 30, 2023
Merged

fix(async): submit additional default aspects only when not in async mode #8320

merged 2 commits into from
Jun 30, 2023

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jun 27, 2023
david-leifker
david-leifker reviewed Jun 30, 2023
View reviewed changes
mock-entity-registry/build.gradle
@@ -0,0 +1,5 @@
apply plugin: 'java'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on moving this out for re-usability

@david-leifker david-leifker merged commit 10e5ecf into datahub-project:master Jun 30, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@pedro93 pedro93 Awaiting requested review from pedro93

@iprentic iprentic Awaiting requested review from iprentic

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyanHolstien @david-leifker