feat(ui) Show Acryl information with button and banner behind flag #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
joshuaeilers
approved these changes
Jun 29, 2023
Comment on lines
+11
to
+12
| color: #262626; | ||
| background-color: #e6f4ff; |
There was a problem hiding this comment.
May be nice to put these into a constants, but I bet they're only used here for now. If so, it's fine the way it is.
There was a problem hiding this comment.
ugh yeah these are only used here right now but I bet they may be involved in the color overhaul that's coming
| `; | ||
|
|
||
| const StyledLink = styled(Link)` | ||
| color: #1890ff; |
There was a problem hiding this comment.
Same question about this color.
Comment on lines
+11
to
+14
| export function useIsShowAcrylInfoEnabled() { | ||
| const appConfig = useAppConfig(); | ||
| return appConfig.config.featureFlags.showAcrylInfo; | ||
| } |
There was a problem hiding this comment.
Thank you for making this a shared hook ❤️
| @@ -289,6 +289,7 @@ featureFlags: | |||
| showBrowseV2: ${SHOW_BROWSE_V2:true} # Enables showing the browse v2 sidebar experience. | |||
| preProcessHooks: | |||
| uiEnabled: ${PRE_PROCESS_HOOKS_UI_ENABLED:true} # Circumvents Kafka for processing index updates for UI changes sourced from GraphQL to avoid processing delays | |||
| showAcrylInfo: ${SHOW_ACRYL_INFO:true} # Show different CTAs within DataHub around moving to Managed DataHub. Set to true for the demo site. | |||
There was a problem hiding this comment.
Default to false here probably?
There was a problem hiding this comment.
oh man amazing call haha woops! i forgot to switch it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a few desired Managed DataHub / Acryl CTAs that are hidden behind a feature flag that is default off. We will turn this on in our demo site to show a button to book a demo and a banner on the home page.
Checklist