fix(ingest/sql-common): Fix profile_table_level_only #8331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Jun 29, 2023
| @@ -351,65 +351,7 @@ | |||
| }, | |||
| "rowCount": 2, | |||
| "columnCount": 9, | |||
| "fieldProfiles": [ | |||
There was a problem hiding this comment.
just confirming that this change is actually correct
kinda hard to understand the correspondence between the yml files and the golden files - they really should've been named better
There was a problem hiding this comment.
Yup, this is what no fields profiled looks like
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug but I do not know why we're supporting profiling some table level values when
profile_table_level_onlyis provided. Also makes it so we don't send field profiles if we're not ingesting any columns.Checklist