Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ingest/nifi): Configure nifi tests for arm64 #8363

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

asikowitz
Copy link
Collaborator

Bumps the nifi version which changes the custom property set (now expanded).
Also checks a url every 10 seconds for when nifi is done executing, rather than sleeping for 120 seconds always

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jul 4, 2023
for i in range(12):
if requests.get(url).status_code == 200:
break
time.sleep(10)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wait is not only for the nifi to start up but also for nifi workflow to execute and process all events. The current check only verifies if nifi is up. To check whether workflow has run completely and it has generated necessary provenance events, we'll need to call provenance api here and probably check the count of events has reached expected count.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I made a change here, lmk what you think. I'm not exactly sure what the API is saying but this seems like what changes between when the api endpoint first opens and its final state. Would prefer to avoid the full 2 minute wait just to keep things as quick as possible, if possible.

@asikowitz
Copy link
Collaborator Author

I broke the commits down between (i) expanding MCPs and (ii) changes made by the updates. Everything remains the same except some properties change, and urn:li:dataJob:(urn:li:dataFlow:(nifi,80820b2f-017d-1000-85cf-05f56cde9185,PROD),c8c73d4c-ebdd-1bee-9b46-629672cd11a0) loses an inputDatajob (order also seems to change). That seems somewhat concerning to me and this difference persists even with the flat 120 second wait. @mayurinehate does this seem concerning to you?

Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asikowitz asikowitz merged commit 74301ec into datahub-project:master Jul 7, 2023
42 of 44 checks passed
@asikowitz asikowitz deleted the nifi-arm branch July 7, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants