-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ingest/nifi): Configure nifi tests for arm64 #8363
Conversation
for i in range(12): | ||
if requests.get(url).status_code == 200: | ||
break | ||
time.sleep(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wait is not only for the nifi to start up but also for nifi workflow to execute and process all events. The current check only verifies if nifi is up. To check whether workflow has run completely and it has generated necessary provenance events, we'll need to call provenance api here and probably check the count of events has reached expected count.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I made a change here, lmk what you think. I'm not exactly sure what the API is saying but this seems like what changes between when the api endpoint first opens and its final state. Would prefer to avoid the full 2 minute wait just to keep things as quick as possible, if possible.
I broke the commits down between (i) expanding MCPs and (ii) changes made by the updates. Everything remains the same except some properties change, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Bumps the nifi version which changes the custom property set (now expanded).
Also checks a url every 10 seconds for when nifi is done executing, rather than sleeping for 120 seconds always
Checklist