Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/presto-on-hive): enable partition key for presto-on-hive #8380

Conversation

zheyu001
Copy link
Contributor

@zheyu001 zheyu001 commented Jul 7, 2023

What?

Enable partition key for presto-on-hive.

  1. Update mapper to set is partitioning key as expected.
  2. Update graphql configs to query the new field.
  3. Update webreact to show the badge as shown below.
Screenshot 2023-07-07 at 09 59 39

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Jul 7, 2023
@zheyu001 zheyu001 changed the title feat(ingest): enable partition key for presto-on-hive feat(ingest/presto-on-hive): enable partition key for presto-on-hive Jul 8, 2023
@zheyu001
Copy link
Contributor Author

I don't have permission to run git actions. If anyone has permission can help trigger it, it will be wonderful! Thanks a lot! My local machine is too slow and it stuck at kafka ingest test. 😢

@hsheth2
Copy link
Collaborator

hsheth2 commented Jul 11, 2023

@zheyu001 looks like there are some test failures on this one

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things look good on the graphql / UI side to me!

@zheyu001
Copy link
Contributor Author

Previous failed smoke test seems not related to the changes of this PR, judging by the error message (but I could be wrong given I have limited context about the tests).

Please let me know if there're anythings blocking this from being merged. Thanks! :)

@hsheth2
Copy link
Collaborator

hsheth2 commented Jul 26, 2023

@zheyu001 yup we're having some unrelated issues with our CI right now - we'll manage merging master into this PR and merging it once those issues are resolved.

@anshbansal anshbansal merged commit bf47d65 into datahub-project:master Aug 2, 2023
46 checks passed
@zheyu001 zheyu001 deleted the feature/enable-partition-key-for-presto-on-hive branch August 4, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants