feat(ingest/nifi): add support for basic auth in nifi #8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurinehate
commented
Jul 19, 2023
| @@ -667,41 +669,8 @@ def fetch_provenance_events( | |||
| of processor type {processor.type}, Start date: {startDate}, End date: {endDate}" | |||
| ) | |||
|
|
|||
| older_version: bool = self.nifi_flow.version is not None and version.parse( | |||
There was a problem hiding this comment.
refractored into separate method.
mayurinehate
commented
Jul 19, 2023
| @@ -1001,8 +1035,6 @@ def get_workunits_internal(self) -> Iterable[MetadataWorkUnit]: | |||
| self.report.report_failure(self.config.site_url, "Failed to authenticate") | |||
| return | |||
|
|
|||
| self.session.headers.update({"Content-Type": "application/json"}) | |||
There was a problem hiding this comment.
this is not required. Most of the nifi requests connector calls accept content-type: */*
mayurinehate
changed the title
github-actions
bot
added
the
ingestion
hsheth2
added
the
merge-pending-ci
|
Cypress tests should be unaffected by these changes, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist