fix(ui) Fix broken dataPlatformInstance references in browseV2 #8485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscollins3456
changed the title
jjoyce0510
reviewed
Jul 21, 2023
| @@ -42,7 +43,7 @@ const BrowseNode = () => { | |||
| const platformAggregation = usePlatformAggregation(); | |||
| const browseResultGroup = useBrowseResultGroup(); | |||
| const { count, entity } = browseResultGroup; | |||
| const hasEntityLink = !!entity; | |||
| const hasEntityLink = !!entity && entity.type !== EntityType.DataPlatformInstance; | |||
jjoyce0510
approved these changes
Jul 21, 2023
david-leifker
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new search and browse experiences, we introduced dataPlatformInstances to a new place where they are treated like full-blown entities. For example, a dataPlatformInstance urn will often be in browse paths. We then try to use the entity registry in many different places to render an entity name, but would get an error thrown if we tried to do that for a dataPlatformInstance.
This PR adds
DataPlatformInstanceEntitiyto the frontend entity registry so we can render the display name properly. The other pieces are unimportant and will be unused entirely (we never try to render a profile for a data platform instance). What's more, is that if we ever tried to do any of these methods anywhere else in the app, the app would just crash like it did when I tried to get entity name so this is definitely a win.Checklist