Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): allow relative start time config #8562

Merged
merged 10 commits into from
Aug 15, 2023
Merged

feat(ingest): allow relative start time config #8562

merged 10 commits into from
Aug 15, 2023

Conversation

mayurinehate
Copy link
Collaborator

  1. allow start_time to be specified as relative datetime string - helps to specify lookback window in terms of days. This will allows scheduling ingestion recipes with dynamic lookback window.
  2. validators to ensure relative start time is negative and is sufficiently wide.
  3. validator to ensure calculated/specified start time aligns with bucket start time
  4. tests for backward compatibility and relative start time

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

mayurinehate and others added 2 commits August 3, 2023 16:31
@mayurinehate
feat(ingest): allow relative start time
f148f23 
1. allow start_time to be specified as relative datetime string
2. validators to ensure relative start time is negative and is sufficiently wide.
3. validator to ensure calculated/specified start time aligns with bucket start time
4. tests for backward compatibility and relative start time
@mayurinehate
Merge branch 'master' into relate_start_end_time
c408980
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 3, 2023
hsheth2
hsheth2 reviewed Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks but otherwise lgtm

metadata-ingestion/src/datahub/ingestion/source/usage/usage_common.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/usage/usage_common.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 merged commit ddcd510 into datahub-project:master Aug 15, 2023
44 checks passed
@asikowitz asikowitz mentioned this pull request Aug 17, 2023
Merged
5 tasks
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@mayurinehate @hsheth2 @asikowitz
feat(ingest): allow relative start time config (datahub-project#8562)
5d8c20d 
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@mayurinehate @hsheth2 @yoonhyejin
feat(ingest): allow relative start time config (#8562)
742bb90 
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @hsheth2