fix(ingest): Add client_certificate_path for rest client cert instead of ca_certif… #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Aug 10, 2023
hsheth2
added
the
merge-pending-ci
Yes, that is correct. |
5 tasks
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
… of ca_certif… (#8581) Co-authored-by: Kamalaseshan Radha <mkamalas@LAMU02DN212MD6R.uhc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…icate_path
Prior to v10.0.3, we are passing server side certificate in the ca_certificate_path and this is used for ssl verification. With the PR - #7978, this has been changed to cert (client certificate) and this causes ssl handshake failure.
The proposal in this PR is to use a new parameter for client_certificate_path for client certificate and reset old parameter as verify for server cert verification.
Checklist