Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(8584): emit data_platform_instance aspect if the config has platform_instance #8585

Merged
merged 3 commits into from
Aug 17, 2023
Merged

bug(8584): emit data_platform_instance aspect if the config has platform_instance #8585

merged 3 commits into from
Aug 17, 2023

Conversation

jinlintt
Copy link
Contributor

@jinlintt jinlintt commented Aug 7, 2023 •
edited

This addresses the following issue:
#8584

I updated the golden files by running the following commands:

cd metadata-ingestion
./gradlew -Pextra_pip_requirements='sqlalchemy~=1.4.0 apache-airflow>=2.4.0' installDevTest
source venv/bin/activate
pytest tests/integration/s3/test_s3.py::test_data_lake_s3_ingest --update-golden-files
pytest tests/integration/s3/test_s3.py::test_data_lake_local_ingest --update-golden-files

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 7, 2023
@hsheth2 hsheth2 requested a review from asikowitz August 9, 2023 00:36
hsheth2
hsheth2 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, just checking with @asikowitz to confirm

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 16, 2023
@anshbansal anshbansal merged commit 6748aec into datahub-project:master Aug 17, 2023
44 checks passed
@hsheth2 hsheth2 mentioned this pull request Aug 17, 2023
Closed
@jinlintt jinlintt mentioned this pull request Aug 21, 2023
Merged
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@jinlintt @asikowitz
fix(ingest/s3): emit data_platform_instance aspect if the config has …
677022d 
…platform_instance (datahub-project#8585)
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@jinlintt @yoonhyejin
fix(ingest/s3): emit data_platform_instance aspect if the config has …
827181d 
…platform_instance (#8585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@asikowitz asikowitz Awaiting requested review from asikowitz

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jinlintt @hsheth2 @anshbansal