feat(ui) Display consistent search results in embedded searches #8597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaeilers
approved these changes
Aug 9, 2023
indeed i have |
jjoyce0510
reviewed
Aug 16, 2023
| /> | ||
| )} | ||
| {entityRegistry.renderSearchResult(entity.type, searchResult)} | ||
| {entityAction && <EntityAction urn={entity.urn} type={entity.type} />} |
There was a problem hiding this comment.
we can test this using the metadata tests flow on acryl
jjoyce0510
reviewed
Aug 16, 2023
| bordered = true, | ||
| entityAction, | ||
| }: Props) => { | ||
| export const EntityNameList = ({ entities, onClick }: Props) => { |
There was a problem hiding this comment.
Are we still using this component anywhere?
asikowitz
pushed a commit
to asikowitz/datahub
that referenced
this pull request
Aug 23, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes an update so that embedded searches display the same search result card as regular search results. That means we show all the same info (usage stats, owners, all that good stuff).
Previously
EntityNameListwas being used in two different contexts - (1) embedded list searches (2) home page recommendation modules.The tough thing is that in order to display the regular search card, we need the whole
SearchResultobject which we have from embedded list searches but not in home page recommendations. So what I did was pull out the contents ofEntityNameListand create a new component that is essentially the same but instead takes inSearchResultobjects instead ofEntityobjects and use the entity registry'srenderSearchmethod which displays the full search result card.Then I stripped
EntityNameListof any unused functionality so it only does what is needed for it from the recommendation modules. Therefore the diff is a little misleading here.Screenshot:
Checklist