harden autocomplete test #8603
Merged
harden autocomplete test #8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 8, 2023 16:03
github-actions
bot
added
product
joshuaeilers
commented
Aug 9, 2023
Comment on lines
37
to
50
| cy.login(); | ||
| cy.visit("/"); | ||
| cy.get("input[data-testid=search-input]").type("baz"); | ||
|
|
||
| cy.get('[data-testid="auto-complete-option--urn:li:chart:(looker,baz2)"'); | ||
| cy.get('[data-testid="quick-filter-DASHBOARD"]').click(); | ||
| cy.wait(2000); | ||
| cy.get( | ||
| '[data-testid="auto-complete-option--urn:li:chart:(looker,baz2)"' | ||
| ).should("not.exist"); | ||
| cy.contains("Baz Dashboard"); | ||
| cy.wait(1000); | ||
| }); |
There was a problem hiding this comment.
The diff is hard to read... but the change here is is in the selectors in this test. Basically we attach urns to each data-testid in the autocomplete and makes selecting them simple. This way, we don't accidentally select "Baz Chart 2" which is sitting behind the autocomplete on a couple of links.
chriscollins3456
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist