Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove documentation and link for dataset #8604

Conversation

kkorchak
Copy link
Collaborator

@kkorchak kkorchak commented Aug 9, 2023

Datased documentation test steps:

  1. Open test dataset.
  2. Edit documentation and save, verify documentation saved correctly
  3. Remove documentation, verify documentation removed.
  4. Return documentation to previous state
  5. Add documentation link, verify URL warning and dialog.
  6. Remove documentation link, verify link removed.
  7. Return documentation link to previous state.
  8. Edit and save field documentation(Schema tab)
  9. Return field documentation to previous state.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Aug 9, 2023
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jjoyce0510 jjoyce0510 merged commit 272dcfe into datahub-project:master Aug 17, 2023
32 checks passed
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants