Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): avoid mutable defaults in powerbi dataclass #8609

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix(ingest): avoid mutable defaults in powerbi dataclass #8609

merged 4 commits into from
Aug 17, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 10, 2023 •
edited

Closes #8383.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 10, 2023
@hsheth2 hsheth2 mentioned this pull request Aug 10, 2023
Draft
5 tasks
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 15, 2023
@anshbansal anshbansal merged commit 2f9b5a8 into datahub-project:master Aug 17, 2023
44 checks passed
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@hsheth2 @asikowitz
fix(ingest): avoid mutable defaults in powerbi dataclass (datahub-pro…
8698a22 
…ject#8609)
@hsheth2 hsheth2 mentioned this pull request Aug 23, 2023
Closed
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@hsheth2 @yoonhyejin
fix(ingest): avoid mutable defaults in powerbi dataclass (#8609)
03ea29c
@hsheth2 hsheth2 deleted the powerbi-type branch February 14, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerBI ingestion doesn't work with Python 3.11 (but does work with Python 3.10)
3 participants
@hsheth2 @asikowitz @anshbansal