Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): Add word gram analyzer for name fields #8611

Merged
merged 16 commits into from
Aug 21, 2023
Merged

feat(search): Add word gram analyzer for name fields #8611

merged 16 commits into from
Aug 21, 2023

Conversation

iprentic
Copy link
Contributor

@iprentic iprentic commented Aug 10, 2023 •
edited

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX labels Aug 10, 2023
@iprentic iprentic changed the title WIP feat(search): Add word gram analyzer for name fields feat(search): Add word gram analyzer for name fields Aug 16, 2023
@iprentic
Copy link
Contributor Author

Failing cypress test passes locally, so I am landing this

@iprentic iprentic merged commit 8cf299a into master Aug 21, 2023
54 of 55 checks passed
@iprentic iprentic deleted the nd-word-grams branch August 21, 2023 18:33
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@iprentic @asikowitz
feat(search): Add word gram analyzer for name fields (datahub-project…
46a4b1a 
…#8611)

Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@iprentic @yoonhyejin
feat(search): Add word gram analyzer for name fields (#8611)
349b88c 
Co-authored-by: Indy Prentice <indy@Indys-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@david-leifker david-leifker Awaiting requested review from david-leifker

Assignees
No one assigned
Labels
docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iprentic @RyanHolstien