Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/kafka): use SchemaReference properties instead of dict access #8615

Merged
merged 2 commits into from
Aug 16, 2023
Merged

fix(ingest/kafka): use SchemaReference properties instead of dict access #8615

merged 2 commits into from
Aug 16, 2023

Conversation

Deepankarkr
Copy link
Contributor

@Deepankarkr Deepankarkr commented Aug 11, 2023 •
edited by hsheth2

Fixes #8366.

schema_ref:SchemaReference, was treated like a dictionary.

After update, now schema references attributes are accessible by
SchemaReference properties instead of dictionary subscription.

e.g. schema_ref.name , schema_ref.version , schema_ref.subject

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 11, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 14, 2023
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Aug 15, 2023
@hsheth2 hsheth2 changed the title bug(8366): schema_ref attrs by SchemaReference properties instead of dict subscription fix(ingest/kafka): use SchemaReference properties instead of dict access Aug 15, 2023
@anshbansal anshbansal merged commit 94ce753 into datahub-project:master Aug 16, 2023
44 checks passed
@Deepankarkr Deepankarkr deleted the schema_ref_main branch August 16, 2023 05:14
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@Deepankarkr @hsheth2 @asikowitz
fix(ingest/kafka): use SchemaReference properties instead of dict acc…
8fa8242 
…ess (datahub-project#8615)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@Deepankarkr @hsheth2 @yoonhyejin
fix(ingest/kafka): use SchemaReference properties instead of dict acc…
440d541 
…ess (#8615)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'SchemaReference' object is not subscriptable
4 participants
@Deepankarkr @hsheth2 @anshbansal @maggiehays