feat(ingest/s3): Adding option to pass in any spark config property to s3 source #8621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Aug 14, 2023
| @@ -66,6 +66,11 @@ class DataLakeSourceConfig( | |||
| default="4g", description="Max amount of memory to grant Spark." | |||
| ) | |||
|
|
|||
| spark_config: Dict[str, Any] = Field( | |||
| description="Spark configuration properties to set on the SparkSession. Put config property names into quotes. ", | |||
There was a problem hiding this comment.
Could you add a comment with an example spark_config, e.g. one that increases the memory
asikowitz
pushed a commit
to asikowitz/datahub
that referenced
this pull request
Aug 23, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist