chore(ingest/s3) Bump Deequ and Pyspark version #8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
approved these changes
Aug 15, 2023
hsheth2
approved these changes
Aug 15, 2023
| @@ -259,13 +259,14 @@ def init_spark(self): | |||
| import pydeequ | |||
|
|
|||
| conf = SparkConf() | |||
|
|
|||
| spark_version = os.getenv("SPARK_VERSION", "3.0") | |||
metadata-ingestion/setup.py
Outdated
| "pydeequ>=1.0.1, <1.1", | ||
| "pyspark==3.0.3", | ||
| "pydeequ>=1.0.1", | ||
| "pyspark==3.3.2", |
There was a problem hiding this comment.
It might still be good to keep this strictly pinned instead of >=
There was a problem hiding this comment.
Spark 3.3.3 has already been released. Would it be better to fix the version to the 3.3x branch. i.e. compatible release
"pyspark~=3.3.0", so can upgrade Spark with any future micro releases in 3.3?
There was a problem hiding this comment.
make sense, thanks
This was referenced Aug 15, 2023
|
@treff7es looks like CI is failing on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6852
Checklist