Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for dataset deprecation test #8646

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add test case for dataset deprecation test #8646

merged 2 commits into from
Aug 17, 2023

Conversation

kkorchak
Copy link
Collaborator

Added test case for tooltip dataset deprecation to existing test.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Aug 16, 2023
jjoyce0510
jjoyce0510 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ty!

@jjoyce0510 jjoyce0510 enabled auto-merge (squash) August 17, 2023 19:23
@jjoyce0510 jjoyce0510 merged commit 10d3edc into datahub-project:master Aug 17, 2023
25 of 33 checks passed
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@kkorchak @jjoyce0510 @asikowitz
test(): Add test case for dataset deprecation test (datahub-project#8646
f7a3184 
)

Co-authored-by: John Joyce <john@acryl.io>
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@kkorchak @jjoyce0510 @yoonhyejin
test(): Add test case for dataset deprecation test (#8646)
d2dca21 
Co-authored-by: John Joyce <john@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkorchak @jjoyce0510