fix(java) Use alias for name search sorting and fix missing mappings #8648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iprentic
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Want to throw an aliased field on test-models/src/main/pegasus/com/datahub/test/TestEntityInfo.pdl and add a test to MappingsBuilderTest.java? I have an example in my ngrams PR: https://github.com/datahub-project/datahub/pull/8611/files#diff-fc3cb0e02650522d68bf55a60f21a6d6942f0e87c0e61234a8c20c518f62a41a
| private static Map<String, Object> getMappingsForFieldNameAliases(@Nonnull final SearchableFieldSpec searchableFieldSpec) { | ||
| Map<String, Object> mappings = new HashMap<>(); | ||
| List<String> fieldNameAliases = searchableFieldSpec.getSearchableAnnotation().getFieldNameAliases(); | ||
| if (fieldNameAliases.size() > 0) { |
There was a problem hiding this comment.
we technically don't need this check as it will just not execute anything if we call forEach on an empty list but I leave it up to you if you want to remove it!
There was a problem hiding this comment.
yup that makes sense!
iprentic
approved these changes
Aug 18, 2023
chriscollins3456
merged commit a4cb81c
into
datahub-project:master
54 of 55 checks passed
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with our search sorting and this solves both of them.
The simpler one: If an index didn't have a field that we were sorting by (such as
lastOperationTime) ES would throw an error and not return any results from that index. Instead, we want to pretend like that field exists on the index but just not sort in it. This change is just addingunmappedTypeinESUtils.javain our search request.We want to sort by entity name but unfortunately
nameisn't the name of the field in all elastic indices. So now i'm introducing a new concept to ourSearchableAnnotationcalledfieldNameAliaseswhich is an array of possible aliases for a given field. This sets the alias on the mapping so we can sort by it. Thenamealias is going to be_entityNameto avoid any clashes with existing fields and now the frontend sorts on that.Checklist