Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove(ingest/snowflake): Remove legacy snowflake lineage #8653

Merged
merged 6 commits into from
Aug 23, 2023
Merged

remove(ingest/snowflake): Remove legacy snowflake lineage #8653

merged 6 commits into from
Aug 23, 2023

Conversation

asikowitz
Copy link
Collaborator

This has been the default for a long time. I feel good enough about new lineage to remove legacy lineage and would like to stop supporting both

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 17, 2023
mayurinehate
mayurinehate reviewed Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please remove def external_table_lineage_history( from snowflake_query.py ?

mayurinehate
mayurinehate approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@asikowitz
Copy link
Collaborator Author

Merging as:

Execution failed for task ':smoke-test:nodeSetup'.
> Could not resolve all files for configuration ':smoke-test:detachedConfiguration1'.
   > Could not download node-16.8.0-linux-x64.tar.gz (org.nodejs:node:16.8.0)
      > Could not get resource 'https://nodejs.org/dist/v16.8.0/node-v16.8.0-linux-x64.tar.gz'.
         > Read timed out

does not seem related

@asikowitz asikowitz merged commit 8141e2d into datahub-project:master Aug 23, 2023
49 of 51 checks passed
@asikowitz asikowitz deleted the remove-legacy-snowflake-lineage branch August 23, 2023 19:57
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@asikowitz @treff7es
@anshbansal @yoonhyejin
remove(ingest/snowflake): Remove legacy snowflake lineage (#8653)
2d09979 
Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asikowitz @hsheth2 @mayurinehate @treff7es @anshbansal