Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs(ingestion/unity): Hide stack trace on sql parse failure logs #8657

Merged
merged 2 commits into from
Aug 23, 2023
Merged

logs(ingestion/unity): Hide stack trace on sql parse failure logs #8657

merged 2 commits into from
Aug 23, 2023

Conversation

asikowitz
Copy link
Collaborator

Stack traces make people think there are serious errors when there are not

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 17, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@anshbansal
Copy link
Collaborator

Failure are not related to the ingestion code so merging

@anshbansal anshbansal merged commit 4116716 into datahub-project:master Aug 23, 2023
49 of 51 checks passed
asikowitz added a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@asikowitz
logs(ingestion/unity): Hide stack trace on sql parse failure logs (da…
f218d3e 
…tahub-project#8657)
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@asikowitz @yoonhyejin
logs(ingestion/unity): Hide stack trace on sql parse failure logs (#8657
e2a1525 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@treff7es treff7es Awaiting requested review from treff7es

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asikowitz @anshbansal @hsheth2