Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/ldap): Handle case when 'objectClass' not in attrs #8658

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix(ingest/ldap): Handle case when 'objectClass' not in attrs #8658

merged 2 commits into from
Aug 23, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from hsheth2 August 17, 2023 15:30
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 17, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@asikowitz
Copy link
Collaborator Author

Merging as CI failures should not be related

@asikowitz asikowitz merged commit 01ae5d9 into datahub-project:master Aug 23, 2023
47 of 51 checks passed
@asikowitz asikowitz deleted the ldap-robustness branch August 23, 2023 19:58
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@asikowitz @yoonhyejin
fix(ingest/ldap): Handle case when 'objectClass' not in attrs (#8658)
4ee6d38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asikowitz @hsheth2