Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/bigquery): Add config option to create DataPlatformInstance, default off #8659

Merged
merged 4 commits into from
Aug 24, 2023
Merged

fix(ingest/bigquery): Add config option to create DataPlatformInstance, default off #8659

merged 4 commits into from
Aug 24, 2023

Conversation

asikowitz
Copy link
Collaborator

The data platform instance results in redundancy in the UI browse path for bigquery entities, which is confusing some users. We keep the option to create the DPI aspect for users who want it

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Aug 17, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 22, 2023
@anshbansal
Copy link
Collaborator

lint failure @asikowitz

@anshbansal anshbansal merged commit 22c35f1 into datahub-project:master Aug 24, 2023
50 of 51 checks passed
@anshbansal
Copy link
Collaborator

cypress test is unrelated to this code so merging.

@asikowitz asikowitz deleted the bigquery-dpi-default-off branch August 24, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@treff7es treff7es Awaiting requested review from treff7es

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asikowitz @anshbansal @hsheth2