Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(superset): get alternate platform value if sqlalchemy_uri param is missing #8667

Merged
merged 5 commits into from
Aug 28, 2023
Merged

fix(superset): get alternate platform value if sqlalchemy_uri param is missing #8667

merged 5 commits into from
Aug 28, 2023

Conversation

akhil7philip
Copy link
Contributor

@akhil7philip akhil7philip commented Aug 18, 2023 •
edited

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 18, 2023
@akhil7philip akhil7philip mentioned this pull request Aug 18, 2023
Closed
@akhil7philip
Copy link
Contributor Author

Issue raised regarding this: #8668

@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Aug 21, 2023
@vercel
Copy link

vercel bot commented Aug 23, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 23, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Aug 23, 2023

@akhil7philip thanks for the PR! I made a small tweak but otherwise should be good to merge

@anshbansal anshbansal merged commit ada40e6 into datahub-project:master Aug 28, 2023
51 checks passed
@akhil7philip akhil7philip deleted the superset-database-platform branch September 7, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akhil7philip @hsheth2 @anshbansal @maggiehays