Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few view select issues #8670

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Fix a few view select issues #8670

merged 3 commits into from
Aug 21, 2023

Conversation

joshuaeilers
Copy link
Contributor

@joshuaeilers joshuaeilers commented Aug 18, 2023 •
edited

Screenshot 2023-08-18 at 2 44 59 PM Screenshot 2023-08-18 at 2 45 03 PM

@joshuaeilers joshuaeilers marked this pull request as ready for review August 18, 2023 16:41
@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Aug 18, 2023
@jjoyce0510
Copy link
Collaborator

Only thing i'd say: Can we collapse some of the left-side padding / margin

@joshuaeilers joshuaeilers changed the title chore(views): adjust copy on view select Fix a few view select issues Aug 18, 2023
chriscollins3456
chriscollins3456 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@joshuaeilers joshuaeilers merged commit a17ed80 into datahub-project:master Aug 21, 2023
30 of 39 checks passed
@joshuaeilers joshuaeilers deleted the je--adjust-view-select-copy branch August 21, 2023 16:47
asikowitz pushed a commit to asikowitz/datahub that referenced this pull request Aug 23, 2023
@asikowitz
Fix a few view select issues (datahub-project#8670)
23af970
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@yoonhyejin
Fix a few view select issues (#8670)
20e179c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuaeilers @jjoyce0510 @chriscollins3456