fix(docker): misc docker fixes #8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
david-leifker
force-pushed
the
docker-build-fixes
branch
from
7d89d2b
to
2c740c9
Compare
david-leifker
force-pushed
the
docker-build-fixes
branch
from
2c740c9
to
054990e
Compare
5 tasks
anshbansal
approved these changes
Aug 20, 2023
anshbansal
added
the
merge-pending-ci
david-leifker
force-pushed
the
docker-build-fixes
branch
from
054990e
to
4d99bd8
Compare
david-leifker
force-pushed
the
docker-build-fixes
branch
from
4d99bd8
to
474280e
Compare
david-leifker
force-pushed
the
docker-build-fixes
branch
from
474280e
to
65f1c93
Compare
disable one unreliable golden test
hsheth2
approved these changes
Aug 21, 2023
| @@ -572,9 +568,9 @@ jobs: | |||
| run: ./gradlew :metadata-ingestion:codegen | |||
| - name: Download Base Image | |||
| uses: ishworkh/docker-image-artifact-download@v1 | |||
| if: ${{ needs.setup.outputs.publish != 'true' }} | |||
| if: ${{ needs.setup.outputs.publish != 'true' && steps.filter.outputs.datahub-ingestion-base == 'true' }} | |||
There was a problem hiding this comment.
not a blocker for this PR, but eventually I'd like to move all of the filtering logic (including dorny/paths-filter@v2 and these checks) into setup, so that the remainder of the workflow doesn't have any boolean logic
move docker image clean-up earlier
|
Only failures left are Vertica one + 2 cypress one. We will take them up individually. This should improve our CI situation for now. |
5 tasks
asikowitz
pushed a commit
to asikowitz/datahub
that referenced
this pull request
Aug 23, 2023
yoonhyejin
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist