Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cleanup): cleanup of 1 sub-module #8678

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix(cleanup): cleanup of 1 sub-module #8678

merged 2 commits into from
Aug 24, 2023

Conversation

anshbansal
Copy link
Collaborator

Follow up of #8616

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 20, 2023
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 23, 2023
@anshbansal anshbansal merged commit 9472636 into master Aug 24, 2023
39 of 42 checks passed
@anshbansal anshbansal deleted the aseem-cleanup-fix-part2 branch August 24, 2023 07:39
@anshbansal
Copy link
Collaborator Author

Failures are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshbansal @hsheth2