Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: separate airflow build and test #8688

Merged
merged 25 commits into from
Aug 30, 2023
Merged

ci: separate airflow build and test #8688

merged 25 commits into from
Aug 30, 2023

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Aug 22, 2023
hsheth2
hsheth2 reviewed Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far

.github/workflows/airflow-plugin.yml Outdated Show resolved Hide resolved
metadata-ingestion-modules/airflow-plugin/build.gradle Outdated Show resolved Hide resolved
.github/workflows/airflow-plugin.yml Outdated Show resolved Hide resolved
@mayurinehate mayurinehate marked this pull request as ready for review August 28, 2023 10:41
hsheth2
hsheth2 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things, but lgtm other than that

.github/workflows/airflow-plugin.yml Outdated Show resolved Hide resolved
metadata-ingestion-modules/airflow-plugin/setup.py Outdated Show resolved Hide resolved
@mayurinehate @hsheth2
Update .github/workflows/airflow-plugin.yml
b85d58b 
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
@vercel
Copy link

vercel bot commented Aug 30, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 30, 2023
@hsheth2 hsheth2 merged commit e867dbc into datahub-project:master Aug 30, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @hsheth2