Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow frontend to use http proxy #8691

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Allow frontend to use http proxy #8691

merged 5 commits into from
Aug 31, 2023

Conversation

githendrik
Copy link
Contributor

Hi all,

following a discussion on Slack, I would like to propose the following changes to datahub:

Allow passing of environment variables to the datahub-frontend-react container to make it use a proxy when connecting to external services (namely OIDC providers).

This is my first PR here, so please let me know if I missed anything. I believe the PR checklist is fulfilled, but maybe I missed something else? Happy to change anything not up-to-par!

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs devops PR or Issue related to DataHub backend & deployment labels Aug 22, 2023
@RyanHolstien RyanHolstien merged commit d78a790 into datahub-project:master Aug 31, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants