Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schemaRegistry): change api servlet check to only apply to internal to fix glue support #8693

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix(schemaRegistry): change api servlet check to only apply to internal to fix glue support #8693

merged 2 commits into from
Aug 28, 2023

Conversation

RyanHolstien
Copy link
Collaborator

@RyanHolstien RyanHolstien commented Aug 22, 2023 •
edited

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien added the bug Bug report label Aug 22, 2023
@RyanHolstien RyanHolstien self-assigned this Aug 22, 2023
@RyanHolstien RyanHolstien changed the title fix(schemaRegistry): change api servlet check to only apply to intern… fix(schemaRegistry): change api servlet check to only apply to internal to fix glue support Aug 22, 2023
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Aug 22, 2023
@david-leifker david-leifker added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 27, 2023
@anshbansal anshbansal merged commit 9c5ab1b into datahub-project:master Aug 28, 2023
39 checks passed
@RyanHolstien RyanHolstien deleted the fix/glueSupport branch August 29, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@pedro93 pedro93 Awaiting requested review from pedro93

@iprentic iprentic Awaiting requested review from iprentic

Assignees

@RyanHolstien RyanHolstien

Labels
bug Bug report devops PR or Issue related to DataHub backend & deployment merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RyanHolstien @david-leifker @anshbansal