feat(ingest): support writing configs to files #8696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `__DATAHUB_TO_FILE_` directive to our config loader.
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Aug 23, 2023
asikowitz
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
I'm missing context on how we intend to use this feature. If this is just to help us run UI ingestions, this seems good. If we're going to suggest others do this, I could see it being confusing and would prefer generating these files in the relevant ConfigModel class rather than having users specify this behavior
| @@ -67,12 +68,40 @@ def list_referenced_env_variables(config: dict) -> Set[str]: | |||
| return set([call[1][0] for call in calls]) | |||
|
|
|||
|
|
|||
| WRITE_TO_FILE_DIRECTIVE_PREFIX = "__DATAHUB_TO_FILE_" | |||
There was a problem hiding this comment.
Is this notion of "directive" a yaml thing or something we've introduce before?
There was a problem hiding this comment.
it's part of "datahub-flavored yaml", which is something I just made up :)
this change is mainly to make it easy to run UI ingestion - don't expect this to be a common way we do things broadly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
__DATAHUB_TO_FILE_directive to our config loader.Some sources (e.g. kafka, bigquery) require paths to files on a local file system. This doesn't work for UI ingestion, where the container needs to be totally self-sufficient.
Checklist