Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to glossary term cards without counts #8705

Conversation

joshuaeilers
Copy link
Contributor

@joshuaeilers joshuaeilers commented Aug 23, 2023

Simple solution to helping users to get related glossary term entities/terms.

Screenshot 2023-08-23 at 3 39 20 PM

@joshuaeilers joshuaeilers force-pushed the je--add-links-to-glossary-term-cards branch from b196c62 to f3b41e1 Compare August 23, 2023 18:23
@joshuaeilers joshuaeilers changed the title Add links to glossary term cards Add links to glossary term cards without counts Aug 23, 2023
@joshuaeilers joshuaeilers marked this pull request as ready for review August 23, 2023 18:24
@chriscollins3456
Copy link
Collaborator

@joshuaeilers since these are just links now and don't have any other info - what do you think about making the color our primary link color (blue/green or whatever) to make it more obvious?

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Aug 23, 2023
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! and nice refactor to reuse this other guy

@joshuaeilers joshuaeilers enabled auto-merge (squash) August 24, 2023 17:16
import { Button } from 'antd';
import styled from 'styled-components/macro';

const ExternalUrlWrapper = styled.span`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rename this

@joshuaeilers joshuaeilers enabled auto-merge (squash) August 24, 2023 17:22
@joshuaeilers joshuaeilers merged commit d15f080 into datahub-project:master Aug 24, 2023
39 of 41 checks passed
@joshuaeilers joshuaeilers deleted the je--add-links-to-glossary-term-cards branch August 24, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants