feat(ui) Create page for managing home page posts #8707
Conversation
github-actions
bot
added
product
| @@ -107,7 +107,31 @@ public static boolean canEditGroupMembers(@Nonnull String groupUrnStr, @Nonnull | |||
| } | |||
|
|
|||
| public static boolean canCreateGlobalAnnouncements(@Nonnull QueryContext context) { | |||
| return isAuthorized(context, Optional.empty(), PoliciesConfig.CREATE_GLOBAL_ANNOUNCEMENTS_PRIVILEGE); | |||
| final DisjunctivePrivilegeGroup orPrivilegeGroups = new DisjunctivePrivilegeGroup( | |||
| ImmutableList.of( | |||
| @@ -74,19 +79,21 @@ export const PostLinkCard = ({ linkPost }: Props) => { | |||
| const link = linkPost?.content?.link || ''; | |||
|
|
|||
| return ( | |||
| <CardContainer type="link" href={link}> | |||
| <CardContainer type="link" href={link} target="_blank" rel="noopener noreferrer"> | |||
There was a problem hiding this comment.
thank you!! so much better than redirecting.
| @@ -143,6 +147,11 @@ export const SettingsPage = () => { | |||
| <TeamOutlined /> <ItemTitle>Ownership Types</ItemTitle> | |||
| </Menu.Item> | |||
| )} | |||
| {showHomePagePosts && ( | |||
| <Menu.Item key="posts"> | |||
| </SubFormItem> | ||
| </> | ||
| )} | ||
| </Form> |
There was a problem hiding this comment.
looks great. copy also improved!
thanks for adding the select with conditional fields
| }) | ||
| .catch((e) => { | ||
| message.destroy(); | ||
| message.error({ content: `Failed to create Post!: \n ${e.message || ''}`, duration: 3 }); |
There was a problem hiding this comment.
minor: i've been trying to remove places where we print the raw backend message, and replace with a console.error + An unknown error occurred for the end user
There was a problem hiding this comment.
hear that
|
|
||
| // Handle the Enter press | ||
| useEnterKeyListener({ | ||
| querySelectorToExecuteClick: '#createPostButton', |
| <PageContainer> | ||
| <PageHeaderContainer> | ||
| <PageTitle level={3}>Home Page Posts</PageTitle> | ||
| <Typography.Paragraph type="secondary">View and manage your DataHub Posts.</Typography.Paragraph> |
There was a problem hiding this comment.
Maybe add something about the posts appearing on the landing page.
"View and manage pinned posts that appear to all users on the landing page. "
There was a problem hiding this comment.
oh yeah so much better
| export default function PostItemMenu({ title, urn, onDelete }: Props) { | ||
| const [deletePostMutation] = useDeletePostMutation(); | ||
|
|
||
| const deleteDomain = () => { |
| title: 'Type', | ||
| dataIndex: '', | ||
| key: 'type', | ||
| render: (record: PostEntry) => PostColumn(record.contentType), |
There was a problem hiding this comment.
reminder: we should make sure the copy shown aligns with what the user created (Announcement vs Link)
There was a problem hiding this comment.
definitely good call will update this
| export const DESCRIPTION_FIELD_NAME = 'description'; | ||
| export const LINK_FIELD_NAME = 'link'; | ||
| export const LOCATION_FIELD_NAME = 'location'; | ||
| export const TYPE_FIELD_NAME = 'switch'; |
There was a problem hiding this comment.
it's called "switch"? does type not work?
There was a problem hiding this comment.
it does lol it used to be called SWITCH_FIELD_NAME but i changed it and forgot to update the value here (even though technically it doesn't matter cuz it's just a const that's used) - but updating!
chriscollins3456
merged commit e12d910
into
datahub-project:master
First off I want to give a HUGE shoutout to @PatrickfBraz for his work that went into this PR here. He did the vast majority of this in his PR here: #8292
His work is what enabled us to push this over the finish line otherwise who knows how long it would take before we got there. So thanks so much again!
This PR creates a new page in settings where users that have the platform privilege for managing home page posts can go to in order to create and delete home page posts of either text or link kind. Right now we don't allow editing since that resolver doesn't exist yet.
This also makes some styling updates to make posts look nicer.
Screenshots:
Checklist