feat(cli): support recursive deletes #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only works on single urns and requires browsepathv2 to be ingested for it to work correctly.
5 tasks
github-actions
bot
added
ingestion
asikowitz
approved these changes
Aug 28, 2023
Comment on lines
+612
to
+618
| andFilters += [ | ||
| { | ||
| "field": "platformInstance", | ||
| "values": [platform_instance], | ||
| "condition": "EQUAL", | ||
| } | ||
| ] |
There was a problem hiding this comment.
Just curious, how is this field set in elasticsearch? Based on urn or based on dataplatforminstance aspect?
There was a problem hiding this comment.
We should properly produce this aspect then, like in a work unit processor
There was a problem hiding this comment.
strongly agree - we're not consistent with it right now
hsheth2
added
the
merge-pending-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only works on single urns and requires browsepathv2 to be ingested for it to work correctly.
Closes #8709.
Checklist