Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ingest/rest): Update rest sink defaults to retry more often #8729

Merged

Conversation

asikowitz
Copy link
Collaborator

@asikowitz asikowitz commented Aug 25, 2023

Pretty significant changes:

  • Attempts retries on 500s. We get these a lot, potentially when gms goes down
  • Increases default retries attempts by one. I believe this will turn wait times from [0, 2, 4] to [0, 2, 4, 8]

This does mean that if you're trying to ingest to a datahub instance that's completely down, it's going to a take a lot longer for that ingestion to run.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from hsheth2 August 25, 2023 18:45
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 25, 2023
@asikowitz asikowitz merged commit d169ee8 into datahub-project:master Aug 26, 2023
51 checks passed
@asikowitz asikowitz deleted the update-rest-emitter-defaults branch August 26, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants