Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/bigquery): Filter out fine grained lineage with no upstreams #8758

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

asikowitz
Copy link
Collaborator

Test confirmed to fail before the 1 line change

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Collaborator Author

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

column_mapping[out_column] = frozenset(
                upstream_column_info.column
                for upstream_column_info in column_lineage.upstreams
                if upstream_column_info.table == table_urn
            )

This line is the true culprit. I could factor this out and only set column_mapping[out_column] if there are upstreams for it, but seemed easier to filter out later on

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 30, 2023
@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 30, 2023
@asikowitz asikowitz merged commit a4e7268 into datahub-project:master Aug 31, 2023
52 checks passed
@asikowitz asikowitz deleted the bigquery-fix-cll branch August 31, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants