Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql-parser): schema-aware output column casing #8760

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat(sql-parser): schema-aware output column casing #8760

merged 2 commits into from
Aug 31, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 30, 2023 •
edited

  • Will do schema-aware casing generation for output columns (previously only applied for input cols)
  • Normalize output column casing for Snowflake to match what we do in our Snowflake connector. Should resolve some downstream issues in the Tableau connector too.

Slack ref: https://datahubspace.slack.com/archives/C02GBGG90CU/p1693397056359769?thread_ts=1692694445.081829&cid=C02GBGG90CU

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(sql-parser): normalize snowflake output columns
cc06c18 
Fixes casing to match with what we do in our Snowflake connector.
Should resolve some downstream issues in the Tableau connector too.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Aug 30, 2023
@hsheth2 hsheth2 changed the title feat(sql-parser): normalize snowflake output columns feat(sql-parser): schema-aware output column casing Aug 30, 2023
@asikowitz asikowitz added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Aug 30, 2023
@hsheth2 hsheth2 merged commit 21b2851 into datahub-project:master Aug 31, 2023
58 checks passed
@hsheth2 hsheth2 deleted the sqlglot-downstream-col-casing branch August 31, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsheth2 @asikowitz @treff7es