Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(siblings): space icons out #8767

Merged

Conversation

joshuaeilers
Copy link
Contributor

@joshuaeilers joshuaeilers commented Sep 1, 2023

A couple of notes for this PR:

  • Search cards suffered from the same icon spacing issue as the new siblings autocomplete that was shown at town hall. The reason it was missed is that dbt/bigquery combo look fine together due to the unique design of those icons.
  • I remember why I didn't reuse the search card logo component. It's currently a bit of tangled up component handling a lot of different icon rendering scenarios for different props (entityLogoComponent, platformLogoUrl, platformLogoUrls) and digging in and consolidating all of that would've taken more time than I had available for this project. For another day I suppose!

Search card after:
Screenshot 2023-08-31 at 4 59 29 PM

Autocomplete after:
Screenshot 2023-08-31 at 4 59 36 PM


Autocomplete before:
Screenshot 2023-08-31 at 4 57 26 PM

Search card before:
Screenshot 2023-08-31 at 4 57 19 PM

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 1, 2023
@joshuaeilers joshuaeilers marked this pull request as ready for review September 1, 2023 00:05
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@joshuaeilers joshuaeilers merged commit 23f24f4 into datahub-project:master Sep 1, 2023
42 checks passed
@joshuaeilers joshuaeilers deleted the je--spaced-sibling-icons branch September 1, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants