Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:fix broken img links under managed-datahub #8769

Merged
merged 3 commits into from
Sep 1, 2023
Merged

docs:fix broken img links under managed-datahub #8769

merged 3 commits into from
Sep 1, 2023

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Sep 1, 2023
@yoonhyejin yoonhyejin marked this pull request as draft September 1, 2023 02:46
@yoonhyejin yoonhyejin marked this pull request as ready for review September 1, 2023 02:49
hsheth2
hsheth2 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can we use some tools to auto detect these broken links?

@yoonhyejin
Copy link
Collaborator Author

yoonhyejin commented Sep 1, 2023 •
edited

lgtm

can we use some tools to auto detect these broken links?

@hsheth2 Great idea, actually we can add markdown-link-check somewhere in github action or pre-commit. I'll open another PR on this.

Also, I think you should force-merge on this one. :(

@hsheth2 hsheth2 merged commit 5458c6b into master Sep 1, 2023
2 checks passed
@hsheth2 hsheth2 deleted the docs/fix-broken-links branch September 1, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@gabe-lyons gabe-lyons Awaiting requested review from gabe-lyons

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoonhyejin @hsheth2