docs:upgrade docusaurus version #8770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsheth2
reviewed
Sep 1, 2023
docs-website/yarn.lock
Outdated
There was a problem hiding this comment.
Looks like some of the docsearch and algolia packages didn't get upgraded
There was a problem hiding this comment.
🤦♀️ my bad. just manaually updated missing packages & regenerated yarn.lock again. Could you check if this is okay?
hsheth2
approved these changes
Sep 1, 2023
docs-website/yarn.lock
Outdated
hsheth2
reviewed
Sep 1, 2023
docs-website/package.json
Outdated
| @@ -39,7 +39,8 @@ | |||
| "markprompt": "^0.1.7", | |||
| "react": "^18.2.0", | |||
| "react-dom": "18.2.0", | |||
| "sass": "^1.43.2" | |||
| "sass": "^1.43.2", | |||
| "ts-node-dev": "^2.0.0" | |||
There was a problem hiding this comment.
dont think this new dep is necessary
There was a problem hiding this comment.
Yup just updated generateDocsDir for the newer version of ts-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Had to change some imports in Searchbar/index.js due to this change : https://github.com/facebook/docusaurus/pull/8757/files