Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix"Logout with OIDC not working" #8773

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

FirKys
Copy link
Contributor

@FirKys FirKys commented Sep 1, 2023

The logout action used to clear the session but did not trigger SSO to deactivate the token. Therefore, when the session was cleared, the user remained logged into the system.
Fixed issue #8369

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 1, 2023
@david-leifker
Copy link
Collaborator

Thanks!

@david-leifker david-leifker merged commit d308986 into datahub-project:master Sep 3, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants