Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove link-checker from CI #8883

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 21, 2023

It had too many false positives, so can't be a blocking step in CI. However, it was still super useful so we'll just need to manually run it every now and then.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

It had too many false positives, so can't be a blocking step in CI.
However, it was still super useful so we'll just need to manually run it
every now and then.
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Sep 21, 2023

Merging through smoke test failure

@hsheth2 hsheth2 merged commit 4be8fd0 into datahub-project:master Sep 21, 2023
37 of 38 checks passed
@hsheth2 hsheth2 deleted the link-checker branch September 21, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants