Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ingest/graph): Factor out filter logic #8888

Merged
merged 3 commits into from
Sep 28, 2023
Merged

refactor(ingest/graph): Factor out filter logic #8888

merged 3 commits into from
Sep 28, 2023

Conversation

asikowitz
Copy link
Collaborator

Trying to trim down datahub graph a bit. Pretty much just copy pasting, aside from removing self from arguments

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 22, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 22, 2023

@asikowitz looks like there's an import issue with RemovedStatusFilter, but lgtm other than that

mayurinehate
mayurinehate approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@mayurinehate mayurinehate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@asikowitz asikowitz merged commit 833daa8 into datahub-project:master Sep 28, 2023
55 of 56 checks passed
@asikowitz asikowitz deleted the graph-filter-refactor branch September 28, 2023 17:52
Endtry pushed a commit to Endtry/datahub that referenced this pull request Sep 29, 2023
@asikowitz @Endtry
refactor(ingest/graph): Factor out filter logic (datahub-project#8888)
d1f41fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asikowitz @hsheth2 @mayurinehate