feat(ingest/snowflake): support profiling with sampling #8902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
mayurinehate
commented
Sep 26, 2023
| "If enabled, profiling is done on rows sampled from table. Sampling is not done for smaller tables. ", | ||
| ) | ||
|
|
||
| sample_size: int = Field( | ||
| default=1000, | ||
| default=10000, | ||
| description="Number of rows to be sampled from table for column level profiling." |
There was a problem hiding this comment.
Increasing default based on @asikowitz suggestion here
asikowitz
approved these changes
Oct 6, 2023
| ) | ||
| elif self.custom_sql: | ||
| profile.partitionSpec = PartitionSpecClass( | ||
| type=PartitionTypeClass.QUERY, partition="SAMPLE" |
There was a problem hiding this comment.
Do we want want to put custom_sql in the aspect? Hard to make decisions when it's unused
asikowitz
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be easier to review commit-wise
Commit 1 - initial refractor to remove duplicate profiling related code
Commit 2 - snowflake profiling with sampling
Commit 3 - increase default sample size, use fraction based sampling